search

NRajkumar / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

Final keyword in MS VS 2010 #26

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hello

Final keyword in [5eb9f7b] makes build crash.
To fix this, you can change line in fx_system.h:

#if defined(__clang__) || defined(_MSC_VER)

to

#if defined(__clang__) || _MSC_VER1 >= 1700

Original issue reported on code.google.com by anatol1...@gmail.com on 21 Jul 2014 at 8:03

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi Nico, can you take a look at this one?

Original comment by bo...@foxitsoftware.com on 21 Jul 2014 at 4:50

GoogleCodeExporter commented 9 years ago 
We require MSVC 2013 for building chromium. I'm guessing we require the same 
for pdfium?

Original comment by thakis@chromium.org on 21 Jul 2014 at 4:51

GoogleCodeExporter commented 9 years ago 
(Can someone give me bug editing permissions for pdfium, please?)

Original comment by thakis@chromium.org on 21 Jul 2014 at 4:52

GoogleCodeExporter commented 9 years ago 
anatol1988: You mean _MSC_VER, not _MSC_VER1, right?

Since this is one simple line, we can merge this, but it's possible that we 
make changes that won't easily work in 2010 (say, we might start using c++11 
features, possibly.)

Original comment by thakis@chromium.org on 22 Jul 2014 at 3:26

GoogleCodeExporter commented 9 years ago 
Unfortunately, I need to build PDFium with MSVC++ 2008. Last time I tried (a 
couple of days ago), it worked just fine (but I'm building without V8).

Original comment by eb.mat...@gmail.com on 22 Jul 2014 at 9:32

GoogleCodeExporter commented 9 years ago 
As I said, I"m going to merge this patch, but there's a good chance that 2010 
(let alone 2008) will stop working eventually.

Original comment by thakis@chromium.org on 22 Jul 2014 at 9:40

GoogleCodeExporter commented 9 years ago 
Sure, _MSC_VER, not _MSC_VER1.
Thanks for merging. I understand your situation. Maybe I'll create own branch 
to backport new features.

Original comment by anatol1...@gmail.com on 23 Jul 2014 at 6:16

GoogleCodeExporter commented 9 years ago 
https://pdfium.googlesource.com/pdfium/+/10e6c7cce60cf54a7c2e883fa02101bb2921f19
5%5E%21/#F0

Original comment by thakis@chromium.org on 23 Jul 2014 at 5:55