search

NS-Sports / Xkoranate-CE

Collaborative xkoranate continuation by the NS Sports community
Other
4 stars 10 forks source link

Update athletewidget.cpp-Add Skill to txt/csv import #12

Closed kalactin closed 3 years ago

kalactin commented 4 years ago

https://github.com/kalactin/Xkoranate-CE-1/blob/patch-1/src/signuplisteditor/athletewidget.cpp

blackmage37 commented 4 years ago

@kalactin did you test the build? i tried today and text import no longer works.

kalactin commented 4 years ago

Unfortunately, I am not able to test it, due to my computers inability to run 32 bit apps.

blackmage37 commented 4 years ago

ok well i cant approve this PR until we have confirmation that it works, im afraid

kalactin commented 4 years ago

Did you compile the entire github version? Or just the files changed? I think someone said that they couldn’t get the github version to compile, so we might need to find out why spit won’t compile.

blackmage37 commented 3 years ago

@kalactin

Untested changes should never be committed to the master branch. Really, the dev branch (or a new branch specifically for whatever bug you're working on) should be the first place you make changes. Then merge to test for testing. Then merge to master. This prevents us from merging faults into the master branch code, which could break the entire program when someone downloads it in the future.

I would recommend closing submitting a new pull request to the test branch, where the changes can be tested and confirmed. Once confirmed, we can merge them into the master branch. The same applies to #15