search

NS-Sports / Xkoranate-CE

Collaborative xkoranate continuation by the NS Sports community
Other
4 stars 10 forks source link

Home advantage bugged #9

Open blackmage37 opened 4 years ago

blackmage37 commented 4 years ago

CH mentioned a bug with home advantage here: https://forum.nationstates.net/viewtopic.php?f=7&t=55249&p=29225812#p29225812

wherein home advantage is not applied correctly

kalactin commented 4 years ago

In line 21 or nsfsparadigm.h, it mentions “bool homeAdvantage = false”, this may be one of the reasons why the bug is occurring.

blackmage37 commented 4 years ago

as mentioned in the linked post, the issue is that home advantage is a boolean value and the value set in the sport file is never used,

blackmage37 commented 4 years ago

follow up: the problem only applies to the nsfs paradigm, as noted here: https://forum.nationstates.net/viewtopic.php?p=34310057#p34310057

blackmage37 commented 3 years ago

proposed fix here: https://github.com/blackmage37/Xkoranate-CE/commit/81a10cf42c1dd3b0d8fdea4488aca4b06c3a0042

will require recompiling and testing