NS2CDT / NS2Plus

NS2+ mod for Natural Selection 2
5 stars 7 forks source link

Fix probabilities shown in scoreboard #12

Closed L-as closed 6 years ago

L-as commented 6 years ago

The logic was incorrect.

L-as commented 6 years ago

BTW I have not tested this, but @TheRealNin told me to do it anyway.

GhoulofGSG9 commented 6 years ago

Thanks for the PR. I didn't directly merge it because you overwrote the avg. skill vars that are used to display the teams average skill.

L-as commented 6 years ago

Average skills do now not work. No script errors as far as I can see.

GhoulofGSG9 commented 6 years ago

Did you re-enable it? I did reset the given server options as mentioned in the change log so server ops opt into those features again.

L-as commented 6 years ago

Yes, I did.

GhoulofGSG9 commented 6 years ago

Could you post the server's ns2plus config?

L-as commented 6 years ago
{
  "allow_ambient":true,
  "allow_deathstats":true,
  "allow_drawviewmodel":false,
  "allow_mapparticles":true,
  "allow_nsllights":true,
  "autodisplayendstats":true,
  "endstatsteambreakdown":true,
  "modupdater":false,
  "modupdatercheckinterval":15,
  "modupdaterreminderinterval":2,
  "savestats":false,
  "showavgteamskill":true,
  "showplayerskill":false,
  "showprobabilityofteamvictory":false
}
GhoulofGSG9 commented 6 years ago

@Laaas Somehow your config failed to upgrade. The hive skill related options have now a show_ prefix (so e.g. showavgteamskill is now called show_avgteamskill). Checking other servers the config upgraded just fine so I think you may have a file access rights conflict at your server.

L-as commented 6 years ago

Thanks! That makes a lot of sense.