NSAPH-Projects / AirPollution_DistributedLag_ADRD

2 stars 2 forks source link

First Review of Code Scripts #3

Closed laurenflynn closed 2 years ago

laurenflynn commented 2 years ago

File 1 QID Year: Line 32: why is f[2:18] selected? Line 49: the last_year_cont function logic is a little unclear. Lines 74-78: What is [, zip := ZIP][, ZIP := NULL][zip >= 501] doing?

File 2 First Hospitalization: Line 32: what is the difference between ADATE and year?

File 3 Denominator: Line 4 and 55: Why does this file filter to years 2009-2016 but files #1-2 started at 2000? Header says input of denominator data for 2000-2016.

File 5 Single state analysis: Line 40: [, first_hosp := TRUE] unclear what this is doing Line 47: why is exit restricted to after 2009? Lines 91-97: exp_data function is not clear Line 91: why is the list generated in reverse order ie 2016:2009?

File 7 Cont Us: Line 77: Should the variable name be pre2010qid? Why is the analysis restricted to exit after 2009?

daniellebraun commented 2 years ago

tagging @danielmork as well

danielmork commented 2 years ago

Thank you for the questions. See my answers below. Please let me know if there are further questions!

File 1 QID Year: Line 32: why is f[2:18] selected?

Line 49: the last_year_cont function logic is a little unclear.

Lines 74-78: What is [, zip := ZIP][, ZIP := NULL][zip >= 501] doing?

File 2 First Hospitalization: Line 32: what is the difference between ADATE and year?

File 3 Denominator: Line 4 and 55: Why does this file filter to years 2009-2016 but files https://github.com/NSAPH-Projects/AirPollution_DistributedLag_ADRD/issues/1-2 started at 2000? Header says input of denominator data for 2000-2016.

File 5 Single state analysis: Line 40: [, first_hosp := TRUE] unclear what this is doing

Line 47: why is exit restricted to after 2009?

Lines 91-97: exp_data function is not clear

Line 91: why is the list generated in reverse order ie 2016:2009?

File 7 Cont Us: Line 77: Should the variable name be pre2010qid? Why is the analysis restricted to exit after 2009?