search

NSAPH-Projects / school_gun_incidents

Estimate causal and associative effects of firearm-dealer-to-school proximity on school gun incidents in U.S. census tracts
MIT License
0 stars 0 forks source link

helper script should contain only functions #1

Closed audiracmichelle closed 1 year ago

audiracmichelle commented 1 year ago

pull the function call outside of the script

m-qin commented 1 year ago

Good catch @audiracmichelle! Related question, instead of having the function load_packages() in every script (which I believe is still a to-do for most of the scripts), should we just load the relevant packages into each script? Happy to do this.

audiracmichelle commented 1 year ago

sounds good! I do prefer seeing the package list in each script. Can you do this in branch issue-1-2-3 before merging the pull request?

m-qin commented 1 year ago

Yes, will do!