Mauriciogtec/issue14 - Githubissues

NSAPH-Projects / space

SpaCE, the Spatial Confounding Environment, loads benchmark datasets for causal inference methods tackling spatial confounding

https://nsaph-projects.github.io/space/

MIT License

14 stars 5 forks source link

Mauriciogtec/issue14 #27

Closed mauriciogtec closed 1 year ago

mauriciogtec commented 1 year ago

created data/make_dataset.py
data/data.sh now downloads this file.
removed the script portion from space/dataset.py

mauriciogtec commented 1 year ago

The code under if [ "$user_path" != ".dataset_downloads" ] is needed to consider the edge case when the user selects "$user_path" != ".dataset_downloads". Since there was a bug where everything was deleted after download due to using rm <...>.

audiracmichelle commented 1 year ago

I think this specific PR should go into master because that branch will remain exclusively for readers of the CLeaR submission, correct? all other spacebench package related PR will go to dev and then main? is this correct @Naeemkh ?

Naeemkh commented 1 year ago

I think this specific PR should go into master because that branch will remain exclusively for readers of the CLeaR submission, correct? all other spacebench package related PR will go to dev and then main? is this correct @Naeemkh ?

Yes. If it is related to old submission, it is better to be part of master branch. When you are done with that submission, we will drop the master branch and use the main branch. @mauriciogtec, you can change the PR base branch.