search

NSAPH-Projects / space

SpaCE, the Spatial Confounding Environment, loads benchmark datasets for causal inference methods tackling spatial confounding
https://nsaph-projects.github.io/space/
MIT License
14 stars 5 forks source link

Check if the path exist, if not create one #32

Closed Naeemkh closed 1 year ago

Naeemkh commented 1 year ago

In the given example, if the specified path does not exist, the package creates a file with that name, rendering the downloaded data inaccessible.

$ curl -sSL https://raw.githubusercontent.com/NSAPH-Projects/space/master/data/data.sh | bash -s XGBOOST BINARY 893  non_existant_path
mauriciogtec commented 1 year ago

@atrisovic What does the new API does when the path doesn't exist? @Naeemkh Should we raise a valueerror? Maybe it's raised automatically.

atrisovic commented 1 year ago

We can keep this one and close #11

mauriciogtec commented 1 year ago

Solved in #94