Closed atrisovic closed 1 year ago
Merging #42 (177172a) into dev (0bc3a12) will increase coverage by
7.13%
. The diff coverage isn/a
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## dev #42 +/- ##
==========================================
+ Coverage 40.00% 47.13% +7.13%
==========================================
Files 3 3
Lines 195 157 -38
==========================================
- Hits 78 74 -4
+ Misses 117 83 -34
Flag | Coverage Δ | |
---|---|---|
unittests | 47.13% <ø> (+7.13%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
spacebench/datasets/datasets.py | 42.24% <ø> (+7.82%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I think this is a good step forward.
What's still missing is to use a masterfile with the available datasets instead of hardcoding the name (.e.g, medisynth
) in the code.
I'm going to approve and merge and we can raise a new issue to add the masterfile.
Closes #36
__get_filenames_from_arguments
) then looks for the fileids (__get_fileids_from_filenames
) and then downloads only those files by fileid.