search

NSAPH-Projects / topological-equivariant-networks

E(n)-Equivariant Topological Neural Networks
MIT License
19 stars 0 forks source link

:bug: EMPSN does not increment node indices #17

Closed ekarais closed 5 months ago

ekarais commented 7 months ago

:bug: Potential bug discovery

EMPSN seemingly forgets to increment some tensors that hold node indices during batching, which results in the nodes of the first few graphs being used for all graphs in a batch (default batch size 96). Specifically, the __inc__ function defined in CombinatorialComplexData does not increment attributes that contain x_. These attributes hold node indices and thus should be incremented according to my understanding. This implies that for most graphs in the batch, the node and cell features are completely random (but not the geometric features). I reached out to the authors via email but did not hear back. We could open an issue in their repo. In the meantime, I want to fix the bug and make it a command line option to use the old or new version such that we can still reproduce EMPSN.

ekarais commented 5 months ago

I fixed the bug and added an option to enable it.