NSCC-COGS / Aestheta

An Industrial Think Tank Focused on Developing and Promoting AI Technology for Geospatial Applications [Please note this group was formed as an academic exercise for educational purposes and does not represent a real world organization]
MIT License
7 stars 3 forks source link

loadModel() function currently wont accept a name argument #82

Open kkmcgg opened 3 years ago

kkmcgg commented 3 years ago

https://github.com/NSCC-COGS/Aestheta/blob/229dbbfe474a2a7740f5e8bf74b0633c80c5feec/Library/core.py#L108

The function works when no name is set by finding the most recent available model in the /Models directory in the git repo: https://github.com/NSCC-COGS/Aestheta/tree/main/Models

However, if an actual model name is specified - the loadModel() function fails.

Add the basic functionality to specify a model by name in the loadModel() function. Optionally: test to see if the specified named model exists - or add other features like finding the SECOND most recent model etc...

ghost commented 3 years ago

@kevinkmcguigan, what format should this accept for model names? Were you thinking of using the full filename or path, e.g., "simpleClassifier_20210302180953_64_HelloEarth100.aist", or generating the filename from a format you have in mind?

ghost commented 3 years ago

Fixed in ff4efca740b5105f3cc67ef32b7d4999f35131ea.

kkmcgg commented 3 years ago

Hey @donuty-party, thanks for addressing this. My intention was to see a simple solution where we could load by the explicit model name for now and then build functionality from there as required. I see you've set up a system so we can be flexible with it in the future. This may work for us! Perhaps we will need to begin brainstorming some of the various attributes that will change across our modes. It seems you've gone to town!

Just a rough thought on variables and attributes we way want to consider capturing in the model class - models may vary by:

Perhaps our model class/objects could contain some instructions and validation information as well. Just a note to be aware of -some functionality in terms of capturing model information exists in, for example, the model class in keras - such as the model summary. We may need to learn some of this as we go.

We can discuss in more detail on Tuesday.

ghost commented 3 years ago

Reverted my changes per #102 and moved them to the 82-load-model-by-name branch.