NSKrstic / STAT545-hw-Krstic-Nikolas

0 stars 0 forks source link

hw01 ready for grading #1

Open NSKrstic opened 6 years ago

NSKrstic commented 6 years ago

@vincenzocoia @gvdr @ksedivyhaley @joeybernhardt @mynamedaike @pgonzaleze @derekcho

https://github.com/NSKrstic/STAT545-hw01-Krstic-Nikolas/blob/master/hw01_gapminder.md

gbraich commented 6 years ago

Mark: ✓+

Review:

README -Nice overview including detailing past experience with R and providing some introductory details -Using Markdown syntax including headers, dividers, bullets, bold and italics made the README easy to read -Nikolas also showed creativity in including an embedded gif and quotation -Had a very through explanation about how edits to the README.md were made -Described making changes locally, pushing/pulling and also linked to the resource he used -Gave some helpful comments on merge conflicts (it’s nice to have this insight from someone who had used Github with collaborators) -Nikolas also commented on how he created the R Markdown document and gave some insight into suppressing different outputs

Gapminder Exploration -Went above and beyond the requirements of the homework assignment -Code was well commented on, and included headings for the various queries into the Gapminder dataset -Included two separate plots which illustrated their points well, included titles, axis titles, and displayed creativity in showing new functions that we have not yet learned in class (eg. 5 year intervals, averages) for both life expectancy and GDP per capita -the code for these plots was not included in the .md file but was in the .Rmd file (I only mention this as I wanted to learn these functions myself after seeing them used)

OliviaTabares commented 6 years ago

Peer review assesment: Mark: ✓+ Nikolas was able to modify the README file succesfully, incorporating several elements of markdown syntax. He also had the recommended workflow discussed in class of making changes locally in R studio and then pulling+pushing them to github, he also provided links to resources he used which is most appreciated. Last, I was thrilled to read that he is into boardgames because I am as well (maybe we can play sometime?) As for the gapminder, he did two exploratory plots showing his knowledge of graphic arguments in R, he also did a statistic summary of the variables. I would have liked to read his interpretation of this plots and statistics in the context of the database, but he covered thoroughly the requirements

ksedivyhaley commented 6 years ago

Correctly named issue: Yes Link to work to be reviewed: Yes Use 4 or more aspects of markdown: Yes (headers, list, images, quote, link) Reflections / how it was done: Yes Gapminder exploration: Yes

Comments:

Note: your mark will be sent out later.