NSKrstic / STAT545-hw-Krstic-Nikolas

0 stars 0 forks source link

Homework 05 Ready for Grading #5

Open NSKrstic opened 7 years ago

NSKrstic commented 7 years ago

You can find my markdown file, data, and plot here:

https://github.com/NSKrstic/STAT545-hw-Krstic-Nikolas/tree/master/hw05

menglinzhou commented 7 years ago

Hi, @NSKrstic ! I am glad to review your homework!!!

Factor Management

Visualization Design

But I want to do more

One more thing

I'm really interested in why your embedding doesn't work.

Overall, it's a check plus work!!

Menglin

wenzhengzzz commented 7 years ago

Starting from the main category, I could tell you did clean up your repository. It is very nice to make data and plots folders in every homework folder. One thing I can suggest is also including links to every homework and their content in a menu so that you can approach them in the future (as your personal cheat sheet). Also, you removed all downstream stuff to keep your repository simple.

Here are more comments for hw5: You explained what you will do on sentence. It was kind of you to help me follow the process very well. I did not find any problems in your coding. However, I noticed you did not figure out the differences between reorder and arrange. For visualization design, I really like the way you adding theme_bw() which makes the plots defined clearly, while it's better to practice changing colors or labels in your plots. In last part, I learned how to use fct_recode from your report!

derekcho commented 6 years ago

Hi @NSKrstic, here are some comments about your hw05:

Your grade will be emailed to you at a later date.