search

NSLS-II-CSX / csxtools

Useful python tools for CSX (23-ID)
http://nsls-ii-csx.github.io/csxtools
Other
4 stars 13 forks source link

Fix Vivek's Additions #35

Closed stuwilkins closed 8 years ago

stuwilkins commented 8 years ago

Attn @ambarb @cmazzoli @mpmdean

This is some cleanup of the code submitted by @vivekthampy Note: the main change apart from not assuming the image is 960x960 is to change the ROI to (x, y, x_size, y_size) which is consistent with scikit-beam.

Also, @vivekthampy you mentioned that adding an ROI significantly reduced processing time, but the benchmarks here don't agree with your statement:

https://nbviewer.jupyter.org/gist/stuwilkins/da3d1b83c213b75b27d5

Do not suggest there is really much benefit in this functionality. I think that @tacaswell is correct in that most time is spent reading images from disk and therefore pushing this into the handler may be the only way to get more significant speed up.

However, I am happy to leave this in and refactor if we can get some magic with the handler.

stuwilkins commented 8 years ago

@NSLS-II-CSX/csxteam @mpmdean @vivekthampy this has just been tagged as version 0.1.6 and will be installed on srv[1,2]

stuwilkins commented 8 years ago

@vivekthampy (Attn @mpmdean) You still need to write unit tests for the mean functions you added image_mean and image_sum. Please can you add them as a pull request by COB today. Thanks.