added unit tests for images_sum and images_mean

NSLS-II-CSX / csxtools

Useful python tools for CSX (23-ID)

http://nsls-ii-csx.github.io/csxtools

Other

4 stars 13 forks source link

added unit tests for images_sum and images_mean #37

Closed vivekthampy closed 8 years ago

vivekthampy commented 8 years ago

@stuwilkins ((Attn @mpmdean) Added the tests. Have not done this before. Hopefully it is correct.

stuwilkins commented 8 years ago

@vivekthampy the tests are failing, can you please fix this up. In future it is usually a good thing to check the Travis build after opening the PR and fix up then.

Also, you can always open the PR before you plan to merge - I often do this - and then comment when you are ready to review.

vivekthampy commented 8 years ago

Just corrected the bug. Testing the build now. Will test in the future before making a pull request.

As for the test, I was trying to have a general use case where the number of images in each even can be different. Not sure how I would do it in a more numpy way. I'll think about it. Any suggestions are welcome.