NSLS-II-CSX / csxtools

Useful python tools for CSX (23-ID)
http://nsls-ii-csx.github.io/csxtools
Other
4 stars 13 forks source link

Error handler text refers to incorrect gain setting for get_fastccd_images #40

Closed ambarb closed 8 years ago

ambarb commented 8 years ago

Should swap the text for missing dark images regarding bgnd2 and bgnd1. Instead, maybe look at gain bits directly for WARNING text. In example below, 59112 is gain 2 setting.

In [25]:

bgnd8 = DataBroker['6364f4e8-d0b2-42e3-b999-2708c56ef1b6'] #[59111]
bgnd2 = None #DataBroker[59112]
bgnd1 = DataBroker['165e034b-83de-4769-b80f-447194e701c5'] #None # DataBroker[''] #[]
data = DataBroker['2e693cc7-27b3-4ac2-90ef-f3d1319d3066'] #[59110]
In [26]:

stack = get_fastccd_images(data, (bgnd8, bgnd2, bgnd1), tag='fccd_image')  #fccd_image_lightfield
images = stack[0]

WARNING:csxtools.utils:Missing dark image for gain setting 1

VS


In [27]:

bgnd8 = DataBroker['6364f4e8-d0b2-42e3-b999-2708c56ef1b6'] #[59111]
bgnd2 = DataBroker['165e034b-83de-4769-b80f-447194e701c5'] #None #DataBroker[59112]
bgnd1 = None # DataBroker[''] #[]
data = DataBroker['2e693cc7-27b3-4ac2-90ef-f3d1319d3066'] #[59110]
In [*]:

stack = get_fastccd_images(data, (bgnd8, bgnd2, bgnd1), tag='fccd_image')  #fccd_image_lightfield
images = stack[0]

WARNING:csxtools.utils:Missing 
dark image for gain setting 2
stuwilkins commented 8 years ago

Fixed for issue #41

tacaswell commented 8 years ago

@stuwilkins Your references are circular

stuwilkins commented 8 years ago

@tacaswell fixed ... see above