Remove hard-coded rows and columns because this changes

NSLS-II-CSX / csxtools

Useful python tools for CSX (23-ID)

http://nsls-ii-csx.github.io/csxtools

Other

4 stars 13 forks source link

Remove hard-coded rows and columns because this changes #78

Open ambarb opened 2 years ago

ambarb commented 2 years ago

https://github.com/NSLS-II-CSX/csxtools/blob/52ff964439005c8340e71d77d2a73b22a71dba05/csxtools/utils.py#L318-L319

two options:

[ ] pass as arguments
[ ] look at fccd descriptors for epics plugin that reshapes the "live" image at the Beamline

[ ] not sure this is even used, so also add deprecation warning

logger.warning("csxtools.utils.fccd_mask() planned for deprecation. Contact beamline staff (CSX@bnl.gov) if you use this function.")

ambarb commented 1 month ago

on second thought, no one uses this function so we should just deprecate it along with 3D and 4D image functions because @danielballan fixed get_fastccd_images() to return the array instead of being a generator (simultaneously with tiled and dask integration https://github.com/NSLS-II-CSX/csxtools/pull/86)