search

NSLS-II-CSX / csxtools

Useful python tools for CSX (23-ID)
http://nsls-ii-csx.github.io/csxtools
Other
4 stars 13 forks source link

Fix versioneer compat with py312 #82

Closed tacaswell closed 1 year ago

tacaswell commented 2 years ago

SafeConfigParser has been deprecated since Python 3.2 and will be removed in py312.

https://github.com/python/cpython/pull/28292 https://bugs.python.org/issue45173 https://github.com/python/cpython/issues/89336

ambarb commented 2 years ago

thanks for doing this. I am not sure ii know what this module even does

tacaswell commented 2 years ago

It is used to make sure the version reported by csxtools.__version__ keeps up-to-date with the git tag without you having to think about it :)

The lines I changed were using a (long) deprecated API in code in the standard library that reads and parses configuration files.

ambarb commented 1 year ago

@tacaswell @mrakitin who is going to merge or is there a reason we are waiting?

tacaswell commented 1 year ago

It is just waiting for someone (you?) to push the button!

ambarb commented 1 year ago

cool. did that. do you generally want beamlines to merge these kinds of things?

mrakitin commented 1 year ago

@ambarb, yes, just to keep the beamline staff in the loop, as the code is more controlled on your side (so in case you pull it on the beamline and use it from sources, there will be no surprises).

ambarb commented 1 year ago

Ok. I need to test other things and also on the Scientific Python Dev so I can sort it out then.

mrakitin commented 1 year ago

This is an update to make sure csxtools.__version__ works with Python 3.12+, which we will deploy in the future once the version is released (which is even not a pre-release at the time of this comment).