search

NSLS-II-CSX / csxtools

Useful python tools for CSX (23-ID)
http://nsls-ii-csx.github.io/csxtools
Other
4 stars 13 forks source link

BLD: fix missing `requirements*.txt` files from the source distribution #85

Closed mrakitin closed 1 year ago

mrakitin commented 1 year ago

This PR resolves the malformed instructions to include the requirements*.txt files to the source distribution (published on PyPI and can be used by the conda-forge recipes).

maffettone commented 1 year ago

A little unfamiliar with the motivation. Are you shipping the requirements* files on pip install so that it is then easier to integrate with by OTHER coda forge recipes after install?

mrakitin commented 1 year ago

Right now the .tar.gz (=sdist, or source distribution) file on PyPI is broken, as it did not include the requirements*.txt files. Those files are used in setup.py: https://github.com/NSLS-II-CSX/csxtools/blob/7f5e4c84ea0c038151124cc1716ac3a4263ae434/setup.py#L7-L11

Therefore, when one attempts to install from sources (that's what conda-forge recipes typically do, and we'd like to switch https://github.com/conda-forge/csxtools-feedstock/blob/82eb6dd97d6cb5575e1c14ea5a7c824f00d005de/recipe/meta.yaml#L9 to use the PyPI sources), it will fail. The contents of the source distribution are managed via MANIFEST.in. Docs: https://packaging.python.org/en/latest/guides/using-manifest-in/.

maffettone commented 1 year ago

This makes sense, thank you!

mrakitin commented 1 year ago

I discussed it with Andi as we need a new version of csxtools soon, so I'll go ahead and will merge and tag it. Thanks for your review, @maffettone!