search

NSLS-II-CSX / profile_collection

BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Refactor StatsPluginCSX once ophyd supports multiple AD versions #11

Open mrakitin opened 5 years ago

mrakitin commented 5 years ago

Motivation: #10

Attn: @danielballan

danielballan commented 5 years ago

Ophyd master now supports multiple AD versions.

mrakitin commented 5 years ago

This is not done as of Deployment 19-2.

ambarb commented 3 years ago

@danielballan @mrakitin did we do this already? Can we count this one as done?

mrakitin commented 3 years ago

It's currently supported in ophyd, the required newer AD plugins can have a corresponding versioned ophyd classes. I guess it may be as simple as replacing the import of StatsPlugins.

ambarb commented 3 years ago

Ok. Is there an example somewhere so I can see what the expected output looks like? I don't understand how this change will effect us. maybe we need to also ask @johnsinsheimer for the specific case of fccd?

johnsinsheimer commented 3 years ago

The FCCD uses AD version R3-3-2 (July 9, 2018) if that is helpful.

mrakitin commented 3 years ago

See e.g. https://github.com/bluesky/ophyd/blob/ed6ecb99347845d802858660a202a8646a3076f5/ophyd/areadetector/plugins.py#L1737-L1746 for StatsPlugin_V33, which is chained from the base StatsPlugin v1-9-1.