NSLS-II-CSX / profile_collection

BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

fccd.exposure() needs to be more fault to user entry of acquire period #20

Closed ambarb closed 4 years ago

ambarb commented 5 years ago

See below were someone forced an acquired period that is shorter than the necessary, calculated acquire time (due to mechanics of fast shutter)

will this break the camera if it is repeatedly treated in this way?

Input> db[107816].config_data('fccd')['primary'][0]

Output> {'primary': [{'fccd_cam_acquire_time': 0.05750000000000001,
   'fccd_cam_acquire_period': 0.5,
   'fccd_cam_image_mode': 1,
   'fccd_cam_num_images': 240,
   'fccd_cam_sdk_version': 'v1.0.0-RC1-33-gbc490e5',
   'fccd_cam_firmware_version': '0x302D',
   'fccd_cam_overscan_cols': 0,
   'fccd_cam_fcric_gain': 0,
   'fccd_cam_fcric_clamp': 0,
   'fccd_dg2_A': 0.0,
   'fccd_dg2_B': 0.0005,
   'fccd_dg2_C': 0.01,
   'fccd_dg2_D': 0.1,
   'fccd_dg2_E': 0.0,
   'fccd_dg2_F': 1e-06,
   'fccd_dg2_G': 0.004,
   'fccd_dg2_H': 0.005,
   'fccd_dg1_A': 0.0,
   'fccd_dg1_B': 0.0535,
   'fccd_dg1_C': 0.0105,
   'fccd_dg1_D': 0.042,
   'fccd_dg1_E': 0.0,
   'fccd_dg1_F': 0.001,
   'fccd_dg1_G': 0.0035,
   'fccd_dg1_H': 0.0535}]}
ambarb commented 5 years ago

Forget the example...it doesn't demonstrate what I said, but we should check that the function prevents this from happening.

ambarb commented 4 years ago

this does