ambarb
commented
3 years ago https://github.com/NSLS-II-CSX/xf23id1_profiles/blob/b4084d6220c5c2d4152b740d9c3b0897f0aabe80/profile_collection/startup/csx1/startup/detectors.py#L86-L116 takes care of these items
Still remaining for skbeam.recip
-
[ ] finished detector size (may be hacking because frame store versus non-frame store don't collect different Q-range (PIXELS)
-
[ ] pixel size (mm)
-
[ ] calibrated center (hacky now, in start document) (PIXELS) - REQUIRES HELPER FUNCTIONS TO NOTIFY
-
[ ] sample distance from detector, which is fixed inside of tardis. (mm) - REQUIRES HELPER FUNCTIONS TO NOTIFY
-
[ ] roi5 details
-
[ ] roi enabled status (or maybe this is in stats)
-
[ ] add shape from HDF5 plugin (this is the shape of the saved image)
We are missing framestore mode. See reference to EPICS code for ADFastCCD.
https://github.com/areaDetector/ADFastCCD/blob/7a01726d0f3889d3c27481018d0c9d7f6f2abcb8/FastCCDApp/Db/FastCCD.template#L245-L257
Do we want to add overscan rows? overscan columns are already present. HOwever, overscan columns looks to use the PV for setting, not the RBV PV. @stuwilkins should this be RBV? All of the code written here was done concurrently with the ADFastCDD development and I think this is one that was missed. Or maybe I do not understand something.
Do we want to add Row instructions from the FastCCD1 plugin that displays live images so we can use this information to automatically shape the image into something the user will want to see when using FrameStore or not using FrameStore?