search

NSLS-II-CSX / profile_collection

BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Darkframes #32

Open mrakitin opened 4 years ago

mrakitin commented 4 years ago

Created on @danielballan's behalf as we discussed in slack it's OK to merge to master.

mrakitin commented 4 years ago

I see. https://github.com/NSLS-II-CSX/xf23id1_profiles/pull/32/commits/87001ee3f7b573b95f24694d23200d92763e8021 can be safely merged as well. Let's keep this PR open until we deploy the required package.

danielballan commented 4 years ago

Status update:

@ambarb Should we include flat field support in this same PR?

ambarb commented 4 years ago

I think it doesn't hurt, but populating that stream will need more testing.

ambarb commented 4 years ago

@danielballan I don't see any where for enable or disable the dark preprocessor. Is this included in what was merged into bluesky today? I don't easily see.

If we don't we can merge this into master until it is easy to turn on and off for all 3. We should be the default to off so we don't create a problem for someone who git pulls to resolve git push

danielballan commented 4 years ago

Sounds good. Progress on this was blocked by resolving the issue where multiple DarkFramePreprocessor instances got in one another's way. This was fixed today by https://github.com/bluesky/bluesky-darkframes/pull/24, released just now in v0.4.0.

danielballan commented 4 years ago

Sorry, I neglected to answer the first part

I don't see any where for enable or disable the dark preprocessor. Is this included in what was merged into bluesky today?

Yes. See https://blueskyproject.io/bluesky-darkframes/reference.html#bluesky_darkframes.DarkFramePreprocessor.disable

It was added yesterday in https://github.com/bluesky/bluesky-darkframes/pull/23 and just released in v0.4.0.

MikeHart85 commented 4 years ago

Looking at this during deployment. Not merging yet. Some comments from @ambarb :