search

NSLS-II-CSX / profile_collection

BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Add FastShutter (XY positioner) to startup #34

Open ambarb opened 4 years ago

ambarb commented 4 years ago

https://github.com/NSLS-II-CSX/xf23id1_profiles/blob/6ca543a61127d2ee08ee8bcdb677f6f768735904/profile_collection/startup/csx1/devices/optics.py#L122-L124

It seems redundant to make a new class PositionerXY() since SlitsXY() already does the same thing. Is it worth making this the same device for slit 3 (pinholes mounted on a plate with specific x,y coordinates) and the fast shutter (X Y positions to define placement in the beam)? Or better to keep things redanant but separate.

ambarb commented 4 years ago

@stuwilkins I think this was your choice. Do you remember the reason you made it specifically for slits instead of a generic Positioner? Were you thinking about future features?