search

NSLS-II-PDF / mmm-experiments

Python package for running multimodal madness experiments with BMM
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Make a few bugfixes to scientific_value #32

Closed matthewcarbone closed 1 year ago

matthewcarbone commented 1 year ago

@maffettone note that this

value = self._value_function(np.array(self._relative_positions_cache), np.array(self._observations_cache))
        value = value.reshape(-1, 1)
value = value.reshape(-1, 1)

is repeated in both ask and report but for now I don't think it's a big deal. The value calculation is fast. Good catch on ask btw.