NSLS-II-PDF / profile_collection

Collection profile
0 stars 4 forks source link

prototype cryostat auto #4

Open CJ-Wright opened 6 years ago

CJ-Wright commented 6 years ago

Attn: @awalter-bnl @tacaswell @mrakitin @stuartcampbell (Please feel free to rope more people in)

stuartcampbell commented 6 years ago

What is the purpose of this, and why are we pushing this now on a friday evening.

CJ-Wright commented 6 years ago

This correctly sets the heater level based off the requested temperature. As to why this is happening friday night, well... you know how these things happen.

stuartcampbell commented 6 years ago

Why are we setting the heater level in ophyd and not in the IOC ? I thought @awalter-bnl and @milinda2014 discussed this and it was going to be done in the IOC so it will be consistent from CSS and bluesky ?

CJ-Wright commented 6 years ago

I would love for this to be done in the ioc. What is the time frame on that?

milinda2014 commented 6 years ago

Controls group thinks this should be done at the ophyd layer. M

Sent from my iPhone

On Jul 13, 2018, at 7:02 PM, Christopher J. Wright notifications@github.com<mailto:notifications@github.com> wrote:

I would love for this to be done in the ioc. What is the time frame on that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/NSLS-II-PDF/profile_collection/pull/4#issuecomment-404974663, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFyWVAsNImh30FapPxJ3LvVrH3mqyjApks5uGScPgaJpZM4VPhc6.

CJ-Wright commented 6 years ago

@milinda2014 what do you mean? This is at the ophyd layer?