search

NSLS-II-QAS / profile_collection

beamline configuration at QAS
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

ENH: Add PE detector #2

Closed tacaswell closed 5 years ago

tacaswell commented 5 years ago

Don't merge this, we need to moving importing from nslsii rather than vendoring it.

Edited by @mrakitin: the PR is mostly done, and ready for merging.

mrakitin commented 5 years ago

@tacaswell, DocumentRouter is not available in the event-model v1.7.0 (deployed at the beamline): https://github.com/NSLS-II/event-model/blob/de271983d3d82f3ea90b0b5153ca7668953f2576/event_model/__init__.py.

mrakitin commented 5 years ago

I rebased on master and resolved 3 minor conflicts. It can be merged now, however I'd like to test it on the beamline before it goes in.

@lcdesilva, can you please arrange a meeting next week, so we can test it?

lcdesilva commented 5 years ago

I will check with Steve and get back to you. Thank you.

lcdesilva commented 5 years ago

Users ran on this branch for a week or so. Everything looks good.