search

NSLS-II-SIX / profile_collection

Collection ipython profile
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

On suspension perform calibration and resume #33

Open danielballan opened 4 years ago

danielballan commented 4 years ago

currently, after calibration there is a RedundantStagingError from sclr. We tries this fix but it did not change the outcome. Needs more effort to understand the cause.

 def beamline_align_v3_for_suspenders():
     # We create a unique run name in case
     # multiple suspenders are tripped at the same time.
     run_name = f'alignment-{str(uuid.uuid4())[:8]}'
+    # Ensure the sclr is unstaged because rel_scan inside m3_check will try
+    # to stage it, just as sure as you're born.
+    yield from bps.unstage(sclr)
     yield from bpp.set_run_key_wrapper(beamline_align_v3(), run=run_name)
+    yield from bps.stage(sclr)

cc @dmgav @mrakitin @cryos

danielballan commented 4 years ago

Our understanding is that this was broken in the old environment as well and perhaps never worked, though maybe with a different error. As you can tell from the many hedge words in the previous sentence, more investigation is needed.

ambarb commented 4 years ago

Note control group is working on the sclr replacement. the IOC for the softglu had a bug for our sclr replacement, but this has been fixed just before COVID. Now we just need an ophyd device.

The hope here was that the replacement of the VME scalar card (no longer manufactured and 10+year old IOC ) will have a better working ioc that plays nicer with bluesky (so no more while loop to ensure that sclr is recorded)

ambarb commented 3 years ago

Chanaka says he has an ophyd device. We are moving the testing to CSX.