NSLS-II-SIX / profile_collection

Collection ipython profile
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

update align.m1pit #7

Open ambarb opened 6 years ago

ambarb commented 6 years ago

Add exception so that yag will be pulled out unless the plan is halted.

Change plan so that yag is always retracted after scan is complete. Users are getting confused. CUrrently, the final position of the m3diag is the initial position of the m3diag.

I understand why it was done this way, this is a hard one for the users to remember on top of all the other things. Staff will just have a 5 second window to RE.halt() if they want the YAG to stay in place.

awalter-bnl commented 6 years ago

This is simple enough to do, I will look at it as soon as @ambarb or @bisogni let me know it is fine to do.

ambarb commented 6 years ago

@bisogni pointed out that for the m3 alignment, we need to have the gc_diag stay where it is so maybe it is best to have an optional argument? For instance, return_2_out = False would put the diagnostic in the orginal postion at the start of the scan. Or maybe after_scan = 'out'

ambarb commented 6 years ago

@awalter-bnl we haven't had a chance to organize out thoughts coherently so that we have a punch list of things for the shutdown.

awalter-bnl commented 6 years ago

@ambarb, @bisogni no problem, so far I have not seen anything that I shouldn't be able to get done in the shutdown (depending on the workload form the bluesky/ophyd update release which this time around is only , medium level bug fixes with no major additions).

FYI I am away on vacation from August 10th to August 21st.