NSLS-II-SIX / sixtools

Software for performing resonant inelastic xray scattering analysis at NSLS-II

https://pypi.org/project/sixtools

Other

1 stars 2 forks source link

Development #13

Closed mpmdean closed 5 years ago

mpmdean commented 5 years ago

This adds basic functionality to create rixs spectra via scikitbeam rixs and plot the result.

See example_notebooks/Analyze_data.ipynb to see how it works.

Ask Mark for scan ids to run the example as I am not sure we want to share these publicly.

awalter-bnl commented 5 years ago

@mpmdean I am in a meeting all day today, I will take a look at this first thing tomorrow morning.

awalter-bnl commented 5 years ago

@mpmdean there are 3 issues preventing the flake8 checks: $ flake8 --max-line-length=115 ./sixtools/rixs_wrapper.py:194:1: W293 blank line contains whitespace ./sixtools/rixs_wrapper.py:212:1: W391 blank line at end of file ./sixtools/rixs_wrapper.py:212:1: W293 blank line contains whitespace

I will read over the code tomorrow morning.

mpmdean commented 5 years ago

@awalter-bnl I just corrected the flake8 checked.

codecov-io commented 5 years ago

Codecov Report

Merging #13 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   43.26%   43.26%           
=======================================
  Files           3        3           
  Lines         282      282           
=======================================
  Hits          122      122           
  Misses        160      160

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 352208c...e116ef8. Read the comment docs.

mpmdean commented 5 years ago

I think all @awalter-bnl 's comments have been addressed.

mpmdean commented 5 years ago

@awalter-bnl It would be useful for us to merge as we would see whether the documentation builds correctly.

awalter-bnl commented 5 years ago

@mpmdean you and I have asked for feedback from some people last Friday, we should give them a few more 'business' days to respond.

mpmdean commented 5 years ago

A blank line after the code-block has been added.

As long as we feel the current version is a sensible implementation, I would prefer to merge and open an issue regarding databroker registry pims / dask. I'm certainly not thinking of this as set in stone.

We have a problem that beamline staff are a bit disengaged from the big questions as they these questions are being mixed up with all sorts of unfamiliar things like flake8/sphynix/complicated conda workflows etc.