search

NSLS-II-SIX / sixtools

Software for performing resonant inelastic xray scattering analysis at NSLS-II
https://pypi.org/project/sixtools
Other
1 stars 2 forks source link

Bringing in GUI #17

Closed awalter-bnl closed 5 years ago

awalter-bnl commented 5 years ago

Add GUI functionality.

(This supersedes #15 after horrendous git workflow problems)

awalter-bnl commented 5 years ago

Just noticed that this specifies that I opened this. For the record (not meaning to steel anyones thunder) it was actually @mpmdean while at my computer !-)

mpmdean commented 5 years ago

Sure

mpmdean commented 5 years ago

Not sure it's a thunderous pull request but thanks!

codecov-io commented 5 years ago

Codecov Report

Merging #17 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   43.26%   43.26%           
=======================================
  Files           3        3           
  Lines         282      282           
=======================================
  Hits          122      122           
  Misses        160      160

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10fe8cf...ed4a3fa. Read the comment docs.

mpmdean commented 5 years ago

Perhaps we can just merge this? I don't envisage anyone else looking at this.

danielballan commented 5 years ago

Yeah, GUI code is hard to review. :+1: for merging.