search

NSLS-II-SIX / sixtools

Software for performing resonant inelastic xray scattering analysis at NSLS-II
https://pypi.org/project/sixtools
Other
1 stars 2 forks source link

Extract region #4

Closed awalter-bnl closed 6 years ago

awalter-bnl commented 6 years ago

This adds a function to extract out a region form the raw data.

mpmdean commented 6 years ago

Thanks. The code looks completely pristine to my (limited) eyes. Can I come over to discuss face-to-face a bit?

I would suggest that we eventually make separate objects describing the processing of the different ROIs of the camera. (I certainly agree we should populate these out of the databroker.) Something very roughly along these lines:

process_dict_low_2theta = {'tag': 'low_2theta', 'ROI': [slice(175, 1609), slice(1:1751)], 'curvature': np.array([0., 0., 0.]), 'bins': None}

process_dict_high_2theta = {'tag': 'high_2theta', 'ROI': [slice(175:1609), slice(1753:3503)], 'curvature': np.array([0., 0., 0.]), 'bins': None}

awalter-bnl commented 6 years ago

sure I am happy to discuss face to face, I am still working through the Travis error on this though !-).

codecov-io commented 6 years ago

Codecov Report

Merging #4 into master will increase coverage by 6.42%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   43.26%   49.68%   +6.42%     
==========================================
  Files           3        5       +2     
  Lines         282      318      +36     
==========================================
+ Hits          122      158      +36     
  Misses        160      160
Impacted Files Coverage Δ
sixtools/preliminary_processing.py 100% <100%> (ø)
sixtools/tests/test_preliminary_processing.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5159a3...eda72ea. Read the comment docs.

awalter-bnl commented 6 years ago

@mpmdean is this used in your code? If not then I will close the PR, I want to avoid having unused code in the repo.

mpmdean commented 6 years ago

@awalter-bnl I copied the [slice, slice] structure, but beyond that, I don't plan to include this, so I think it makes sense to close.

awalter-bnl commented 6 years ago

There is no longer a plan to use this so closing the PR