NSLS-II-SIX / sixtools

Software for performing resonant inelastic xray scattering analysis at NSLS-II
https://pypi.org/project/sixtools
Other
1 stars 2 forks source link

Update for centroided data #48

Closed mpmdean closed 5 years ago

mpmdean commented 5 years ago

This includes routines for processing centroided data.

A couple of notes: -- When coding this, I decided to change the way ROIs are set as the previously used python slices cannot be directly applied to the centroided data. -- Previously setting a ROI redefined the effective zero pixel definition in the returned data. This was okay in itself, but is problematic if one wants to compare image and centroided data. The way that bins are defined was consequently also changed. -- Setup.py was changed to comply with flake8 -- A new notebook was added comparing centroided and non-centroided data. Minor updates to the other notebooks are needed for compatbility. -- Small updates to scikit-beam rixs are also needed to run this.

codecov-io commented 5 years ago

Codecov Report

Merging #48 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   46.45%   46.45%           
=======================================
  Files           3        3           
  Lines         282      282           
=======================================
  Hits          131      131           
  Misses        151      151

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 400d53b...8eee88e. Read the comment docs.

mpmdean commented 5 years ago

Perhaps this can be merged now?