NSLS-II-SIX / sixtools

Software for performing resonant inelastic xray scattering analysis at NSLS-II

https://pypi.org/project/sixtools

Other

1 stars 2 forks source link

Add notebook demonstrating optimize curvature function #50

Closed mpmdean closed 5 years ago

mpmdean commented 5 years ago

This adds a notebook showcasing the functionality in scikit-beam/rixs pull request #20.

mpmdean commented 5 years ago

Perhaps we can merge this now? More for the convenience of me and others in knowing which branch is best to work with than anything else.

mpmdean commented 5 years ago

I removed the extra %matplotlib command btw. In the past, I sometimes found that I got an %inline plot unless I ran this twice, but this seems to work properly ran once in the updated environment.

codecov-io commented 5 years ago

Codecov Report

Merging #50 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   46.45%   46.45%           
=======================================
  Files           3        3           
  Lines         282      282           
=======================================
  Hits          131      131           
  Misses        151      151

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4875e02...b105056. Read the comment docs.

danielballan commented 5 years ago

@mpmdean Thanks for mentioning that. I have not seen that reported before. I have some work-in-progress PRs with the Jupyter team to improve matplotlib--Jupyter interactions, and this is something we will watch for.