NSLS-II-SMI / profile_collection

beamline configuration of SMI
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Implement filter-bank #2

Closed mrakitin closed 5 years ago

mrakitin commented 6 years ago

See discussion here: https://github.com/NSLS-II/nslsii/issues/26

mrakitin commented 6 years ago

The solution is suggested in https://github.com/NSLS-II/nslsii/issues/26#issuecomment-396477217.

tacaswell commented 6 years ago

@prjemian and XPD both also have 'fliter bank' implementations.

prjemian commented 6 years ago

This is a signals-only implementation: https://github.com/APS-USAXS/ipython-usaxs/blob/master/profile_bluesky/startup/10-devices.py#L124-L140, invoked by:

pf4_AlTi = DualPf4FilterBox("9idcRIO:pf4:", name="pf4_AlTi")

It has not yet seen beam time. The controls could be richer such as allowing one to provide the desired attenuation and the support picks the closest match with actual attenuation >= desired value. That logic is better in the IOC, though, where all clients have access to its benefit.

awalter-bnl commented 5 years ago

issue is resolved