search

NSLS-II-SRX / profile_collection

NSLS-II SRX beamline IPython startup files for data collection
https://doi.org/10.1016/j.nima.2022.166505
BSD 3-Clause "New" or "Revised" License
3 stars 6 forks source link

There is 3 copies of M2 #4

Closed tacaswell closed 3 years ago

tacaswell commented 5 years ago

1

https://github.com/NSLS-II-SRX/profile_collection/blob/34b25c4ae38b6aca5e98f0f88c0d15d8a487b718/startup/05-endstation.py#L12-L21 https://github.com/NSLS-II-SRX/profile_collection/blob/34b25c4ae38b6aca5e98f0f88c0d15d8a487b718/startup/05-endstation.py#L35

2

https://github.com/NSLS-II-SRX/profile_collection/blob/34b25c4ae38b6aca5e98f0f88c0d15d8a487b718/startup/05-endstation.py#L24-L32 https://github.com/NSLS-II-SRX/profile_collection/blob/34b25c4ae38b6aca5e98f0f88c0d15d8a487b718/startup/05-endstation.py#L36

3

https://github.com/NSLS-II-SRX/profile_collection/blob/34b25c4ae38b6aca5e98f0f88c0d15d8a487b718/startup/15-optics.py#L177-L183

Note that 3 over-write 1.

We probably should consolidate this to just 1 class and 1 instance.

andrewmkiss commented 5 years ago

I've been meaning to go through the startup scripts and clean them up. I think this class and device can be deleted, as they were part of the old KB system that is not in use anymore. I will confirm this. Also, I want to do some cleanup so I will start to do this and pushing to master.

andrewmkiss commented 4 years ago

This should be taken care of in the "cleanup" pull.

mrakitin commented 3 years ago

This was resolved by @andrewmkiss during the recent rewrite.