NSLS-II-SST / rsoxs_scans

stand alone package for loading and validating RSoXS scans for NSLS-II SST-1 beamline
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

metadata can be modified by scans #13

Closed EliotGann closed 1 year ago

EliotGann commented 1 year ago

I'm not sure if it's a feature or a bug, but it was unexpected for me, depending on the order you run acquisitions, you might get unexpected results. in particular where I noticed this is after doing an angle scan, it leaves the samples in the last rotated state, so when doing another scan and not specifying an angle, it defaults to the last one in the angle scan. I think the solution in general is to pass in a deepcopy of the metadata to the lower level plans rather than the md dict itself. In a lot of cases this is fine, but there can be some unexpected results... but then again, it might be really nice to have a smart plan that "aligns" the sample, in which case you would want to allow for alteration of the sample...

EliotGann commented 1 year ago

I think this is all fixed now