search

NSLS-II-SST / rsoxs_scans

stand alone package for loading and validating RSoXS scans for NSLS-II SST-1 beamline
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Bug: inconsistent input validation between spreadsheet and commandline functions #33

Open pbeaucage opened 1 year ago

pbeaucage commented 1 year ago

The input validation stack between the spreadsheet and the command line do_rsoxs, do_nexafs functions appear to be different: polarizations=90 works in a spreadsheet but from command polarizations requires an Iterable such as a single-element list. It would provide a more consistent user experience to unify the input validation/cleanup code from rsoxs_scans such that the same parameters are accepted for both.

EliotGann commented 1 year ago

In principle I think this is right, however, do_rsoxs and do_nexafs are not ever suggested to be used in general. spreadsheets have a validation step which these commands do not. There is an expectation that if a user is running the commands directly they should know inputs rather than trusting the running code to clean it up as with spreadsheet input.

EliotGann commented 1 year ago

If they stick to the output of the columns from the OUTPUT spreadsheets, it should work perfectly