search

NSLS-II / PyXRF

Fluorescence fitting GUI.
http://nsls-ii.github.io/PyXRF
BSD 3-Clause "New" or "Revised" License
31 stars 23 forks source link

v1.0.25 Fails to save pixel based point spectra #316

Closed xrftrevor closed 3 months ago

xrftrevor commented 6 months ago

BUG significant issue: In MAP fitting Save spectra for pixels in the selected region no longer works

Expected Behavior

Files are save with pixel spectra.

Create plot window with individual spectra.

Current Behavior

Error Failed to Fit Individual Pixel Spectra X -> 'Fit1D' object has no attribute 'hdfpath'

If not asking for Save spectra.... the map is generated.

Possible Solution

This worked fine in earlier version v1.0.17 other versions between 25 not tested.

Steps to Reproduce (for bugs)

1. 2. 3.

Context

Your Environment

W11 -> miniconda -> conda install

dmgav commented 6 months ago

@xrftrevor Could you please outline the steps to reproduce the issue in more detail. I could not reproduce the issue at the first attempt.

xrftrevor commented 6 months ago
  1. Read in data - set default directory then read in a file.
  2. Model - Read in Model parameter file
    • General set the energy window
    • Start fitting

  3. Maps

    • Start XRF Map Fitting
    • Set XY scale to positions (this is an unrelated bug in that it needs to be reset after each map fitting even though the button label will stated positions)

    • Click safe spectra for pixels

                                                        i.      End row 15

                                                 ii.      Start row 15

                                               iii.      End Column 31

                                               iv.      Start XRF Map Fitting

      @. @.

The spectra use to be written to a directory, Scan2d__pixel_fit

I hope this helps. I have used an older version for my current critical analysis to check to see if the detailed fits make sense.

Thank you,

Dennis J. Trevor Tech Manager @.*** Your Optical Fiber Solutions Partner(tm) 19 Schoolhouse Rd. | Somerset, NJ 08873 Office: 732 748 7488 Mobile: 908 385 9597

www.ofsoptics.comhttps://urldefense.com/v3/__http:/www.ofsoptics.com/__;!!P4SdNyxKAPE!CRMT-FEL8_NwFLKcOfpDM53SiP-NTLE3Ns8DZpqjTzreoBK7-zfX3JzbaFIH1HrgBvLF47NtIJaGbQ$

From: Dmitri Gavrilov @.> Sent: Monday, April 8, 2024 5:51 PM To: NSLS-II/PyXRF @.> Cc: Trevor, Dennis J (Dennis) @.>; Mention @.> Subject: Re: [NSLS-II/PyXRF] v1.0.25 Fails to save pixel based point spectra (Issue #316)

You don't often get email from @.**@.>. Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification EXTERNAL

@xrftrevorhttps://github.com/xrftrevor Could you please outline the steps to reproduce the issue in more detail. I could not reproduce the issue at the first attempt.

- Reply to this email directly, view it on GitHubhttps://github.com/NSLS-II/PyXRF/issues/316#issuecomment-2043700109, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BHHCVU2S7JJ2ZSXQU5YQKCLY4MGNTAVCNFSM6AAAAABFDJY7HGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTG4YDAMJQHE. You are receiving this because you were mentioned.Message ID: @.**@.>>

Notice: This communication is subject to our Privacy Policyhttp://www.ofsoptics.com/privacy and is intended only for the individual(s) to whom it is addressed and may contain information that is confidential, proprietary, privileged or otherwise protected from disclosure under law. If you are not the intended recipient, then you are hereby notified that any disclosure or distribution of this information is strictly prohibited. If you believe that you received this information in error, then please advise the sender immediately by return email and permanently delete this communication from your mailbox. - OFS-Privacy-Policy

dmgav commented 6 months ago

Thanks @xrftrevor I fixed both bugs. The fix will be included in v1.0.27. You can also pip-install the fixed version from GitHub.

xrftrevor commented 6 months ago

Thank you, I will upgrade.

Dennis

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Dmitri Gavrilov @.> Sent: Monday, April 8, 2024 10:49:34 PM To: NSLS-II/PyXRF @.> Cc: Trevor, Dennis J (Dennis) @.>; Mention @.> Subject: Re: [NSLS-II/PyXRF] v1.0.25 Fails to save pixel based point spectra (Issue #316)

You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification EXTERNAL

Thanks @xrftrevorhttps://github.com/xrftrevor I fixed both bugs. The fix will be included in v1.0.27. You can also pip-install the fixed version from GitHub.

— Reply to this email directly, view it on GitHubhttps://github.com/NSLS-II/PyXRF/issues/316#issuecomment-2044059010, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BHHCVUYWXQA4JMKCHGC3YVDY4NJL5AVCNFSM6AAAAABFDJY7HGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBUGA2TSMBRGA. You are receiving this because you were mentioned.Message ID: @.***>

Notice: This communication is subject to our Privacy Policyhttp://www.ofsoptics.com/privacy and is intended only for the individual(s) to whom it is addressed and may contain information that is confidential, proprietary, privileged or otherwise protected from disclosure under law. If you are not the intended recipient, then you are hereby notified that any disclosure or distribution of this information is strictly prohibited. If you believe that you received this information in error, then please advise the sender immediately by return email and permanently delete this communication from your mailbox. - OFS-Privacy-Policy