search

NSLS-II / edrixs

An open source toolkit for simulating RIXS spectra based on ED
https://nsls-ii.github.io/edrixs
GNU General Public License v3.0
32 stars 19 forks source link

Mac os #163

Closed mpmdean closed 1 year ago

mpmdean commented 1 year ago

This updates the docs to cover the new conda install for macOS and it pins setuptools, which seems to now be required as anticipated in #157 .

mpmdean commented 1 year ago

I think I've solved most of the issues.

@mrakitin I had some trouble working out how to update the tests. I wasn't sure why 3.10 seems to have been interpreted as 3.1. I guess some quotes are needed or something? I am also unsure how to add macOS test.

mrakitin commented 1 year ago

I think I've solved most of the issues.

@mrakitin I had some trouble working out how to update the tests. I wasn't sure why 3.10 seems to have been interpreted as 3.1. I guess some quotes are needed or something? I am also unsure how to add macOS test.

Yes, quotes are needed, otherwise it's interpreted as float. See https://github.com/bluesky/bluesky/blob/fc4204d424d63ec88410bd61577277a468bd24c6/.github/workflows/testing.yml#L15 as an example.

mpmdean commented 1 year ago

Hi @mrakitin I tried a bit to add the macOS, but I am a bit stuck on how to enable to macOS tests.

mrakitin commented 1 year ago

@mpmdean, please use this example to add macOS runner to the job matrix.

mpmdean commented 1 year ago

Thanks @mrakitin that made it clear how to enable the macOS tests, however, there is a build problem seemingly because install-deps.sh is not suitable for macOS.

I also added python 3.11 test, which work.

Unless this issue is something that is trivial to you (it's not so easy for me), I would be inclined to just remove the macOS tests so that docs can be updated to advertise the mac build. I think many users will find this useful.

mrakitin commented 1 year ago

apt-get is a Debian/Ubuntu specific command, not available on other Linux flavors, nor in macOS. If you want to have a separate set of building scripts for macOS, that would most likely use brew install ... or something similar. I think replicating the steps with conda-forge compilers may solve the issue, but it will imply the dependency on conda.

mpmdean commented 1 year ago

@mrakitin I think I'd like to merge in this form. There are several people who will appreciate documentation for the macOS version that is now available. I left a note to address macOS test in #164.