search

NSLS-II / edrixs

An open source toolkit for simulating RIXS spectra based on ED
https://nsls-ii.github.io/edrixs
GNU General Public License v3.0
32 stars 19 forks source link

update docker process #197

Closed mpmdean closed 7 months ago

mpmdean commented 8 months ago

This implements some changes related to differences in how we configure docker

mpmdean commented 8 months ago

@lajerm would you be able to check this PR?

mpmdean commented 8 months ago

@mrakitin Is the GH actions part of this PR correctly implemented?

mpmdean commented 7 months ago

@mrakitin

The GH action works but it tags the docker image as "master", presumably due to the form of this line https://github.com/NSLS-II/edrixs/blob/97f6fdee36ff56ba45c0b7ef1613977d7c35808f/.github/workflows/docker-image-publish.yml#L34

This line in the instructions defaults to the "latest tag" https://github.com/NSLS-II/edrixs/blob/97f6fdee36ff56ba45c0b7ef1613977d7c35808f/docs/source/user/usedocker.rst?plain=1#L21

I would lean towards changing the label? Which I presume can be done by changing the earlier line to:

tags: latest

What do you think?