search

NSLS-II / eiger-io

I/O tools for the Eiger detector
BSD 3-Clause "New" or "Revised" License
1 stars 9 forks source link

Modify #1

Closed yugangzhang closed 8 years ago

yugangzhang commented 8 years ago

@danielballan make a correction by using list() in np.concatenate

danielballan commented 8 years ago

This is not quite right. Take a look at the example I posted again. The list function should go around zip(...) and nothing else.

danielballan commented 8 years ago

@yugangzhang Please don't merge your pull requests. That removes the opportunity for others to catch errors. For example, your code has a SyntaxError in it. The last parenthesis is one too many.

danielballan commented 8 years ago

I see from your comment on the other issue that this was unintentional. To be helpful (not intending to be aggressive!) I am going to revert your PR. Open a new one.