Check implementations of Zebra box and Eiger detector for all PVs

NSLS-II / lsdc

LSDC - Life Sciences Data Collection

https://nsls-ii.github.io/lsdc

BSD 3-Clause "New" or "Revised" License

3 stars 14 forks source link

Check implementations of Zebra box and Eiger detector for all PVs #13

Open JunAishima opened 3 years ago

JunAishima commented 3 years ago

Refs #10

[x] https://github.com/bluesky/ophyd/blob/master/ophyd/areadetector/detectors.py - verify that implementation of Eiger in Ophyd Areadetector is complete
[x] https://github.com/NSLS-II/nslsii/blob/master/nslsii/detectors/zebra.py - verify that the implementation is complete
[x] Create new zebra device implementation for MX

JunAishima commented 3 years ago

Eiger - once ADBase, FileBase, and the main EigerDetectorCam class are considered, all PVs used in bnlpx_config/det_pv_listEiger.txt are available within the Ophyd implementation of Eiger detector. many of the _RBV PVs used by LSDC are available by querying the same object as where values are put.

JunAishima commented 3 years ago

Verified that zebra implementation in nsls-ii is complete - I checked, but found that it does not have many of the same PVs as we have in the current LSDC code. we decided that it would be better to implement from scratch for use in MX. thus have added a new item to the checklist, "Create new zebra device implementation for MX"

JunAishima commented 3 years ago

zebra implementation instantiated in LSDC code in branch integrate_zebra_ophyd_device with commit 334f48bd09669b95fc3c4c3d5f024ca31889fce7. the implementation has been moved to issue #33.

will keep open so that I can do checking of the eiger implementation

JunAishima commented 3 years ago

Moved the metadata stuff fully into #23 - removed "Implement ability to calculate or obtain full metadata of positions of each image for use by databroker." checkbox item.