search

NSLS-II / metadatastore

DEPRECATED: Incorporated into https://github.com/NSLS-II/databroker
Other
2 stars 11 forks source link

WIP: Uids for all #142

Closed ericdill closed 9 years ago

ericdill commented 9 years ago

Supersedes #140

Note that this is not yet ready for merge, I wanted a place to compare all the changes while I finish the dev on this.

ericdill commented 9 years ago

Ready for review

ericdill commented 9 years ago

Ah, shoot. I need to add uid to the index on mongo

ericdill commented 9 years ago

What in the hell are these python 3 bugs??

tacaswell commented 9 years ago

So, that is interesting. Writing an int literal with a leading 0 makes it base 8 (?!).

>>> 01
1
>>> 02
2
>>> 03
3
>>> 04
4
>>> 05
5
>>> 06
6
>>> 07
7
>>> 08
  File "<stdin>", line 1
    08
     ^
SyntaxError: invalid token
>>> 010
8
>>> 011
9
>>> 012
10
>>> 013
11
>>> 030213
12427
>>>

This is justifiable confusing and was removed in 3 See https://www.python.org/dev/peps/pep-3127/

ericdill commented 9 years ago

@danielballan can I punt this back to you? Only a few changes left and I'm in the car all day today.

danielballan commented 9 years ago

Yes. Thanks for tapping in.

ericdill commented 9 years ago

@danielballan @tacaswell I think this should be good to go. Bugs (#143 in particular) are fixed and tests are passing

ericdill commented 9 years ago

scope_creep 20pic

ghost commented 9 years ago

This looks good to go! Thanks @ericdill !

ericdill commented 9 years ago

5b09484 addresses the discussion of asymmetric insert_* and find_* functions. Assuming travis passes, this should be is ready for final review and/or merge