search

NSLS-II / metadatastore

DEPRECATED: Incorporated into https://github.com/NSLS-II/databroker
Other
2 stars 11 forks source link

Fix search order #192

Closed tacaswell closed 8 years ago

ghost commented 8 years ago

Did you check how much overhead sorting on the cursor adds, especially for large number of events?

tacaswell commented 8 years ago

Part of the API is that the events come out in the order they went in. We are indexing on time so if I am reading the docs right it should not be a big deal.

danielballan commented 8 years ago

Right. Removing sorting amounts to an API break, and indeed databroker tests are failing because of this change. @arkilic, if we want to get a performance boost from dropping sorting, that can be considered -- with coordinated changes downstream.

ghost commented 8 years ago

I checked this out with test data, there is no issue in terms of performance.