NSLS-II / metadatastore

DEPRECATED: Incorporated into https://github.com/NSLS-II/databroker
Other
2 stars 11 forks source link

MNT: Sort events so oldest is first #208

Closed ericdill closed 8 years ago

ericdill commented 8 years ago

Fixes the problem where events are returned newest first. This causes issues in suitcase.

https://gist.github.com/ericdill/11c77848fee4725efdef2a9d4e2fc2c6

ericdill commented 8 years ago

Ok so my solution in NSLS-II/suitcase#8 was to just use metadatastore.get_events_generator. This can wait.

tacaswell commented 8 years ago

Did you mean to close this?

ericdill commented 8 years ago

Yes. @arkilic had some reservations about sorting the events differently in get_events() which is fine by me as I don't need to use get_events() to achieve my objectives for NSLS-II/suitcase#8.

tacaswell commented 8 years ago

We are using an identical sort on get_events_generator

ericdill commented 8 years ago

@tacaswell I really don't care what we do here. Do you want this reopened so you can merge it?