ENH: Add generic insert dispatcher.

NSLS-II / metadatastore

DEPRECATED: Incorporated into https://github.com/NSLS-II/databroker

Other

2 stars 11 forks source link

ENH: Add generic insert dispatcher. #211

Closed danielballan closed 8 years ago

danielballan commented 8 years ago

This obviates bluesky/register_mds.py. Registering metadatastore becomes as simple as:

RE.subscribe('all', metadatastore.commands.insert)

danielballan commented 8 years ago

cc @arkilic I see some problems with the implementation in metadataclient (it was this commit). Take a look at this code.

ghost commented 8 years ago

@danielballan I remember looking at this together. What is the problem here? I think we could look at the name == bulk_insert_events instead of dtype

danielballan commented 8 years ago

I caught a couple problems:

spelling: 'bulk_events' not 'bulk_event'; 'start' not 'run_start'; 'stop' not 'run_stop'
bulk events data type: it's dict, not a list -- see my implementation
bulk events edge case: short-circuit if there are no events

ghost commented 8 years ago

The service layer takes care of these edge cases in terms of validation etc. I will take care of the others.