search

NSLS-II / metadatastore

DEPRECATED: Incorporated into https://github.com/NSLS-II/databroker
Other
2 stars 11 forks source link

Create datasets as empty string #244

Closed licode closed 8 years ago

licode commented 8 years ago

Dataset is taken as empty string due to detector defects. This is also used for suitcase test https://github.com/NSLS-II/suitcase/pull/21.

codecov-io commented 8 years ago

Current coverage is 90.76% (diff: 100%)

Merging #244 into master will not change coverage

@@             master       #244   diff @@
==========================================
  Files             6          6          
  Lines           552        552          
  Methods           0          0          
  Messages          0          0          
  Branches         88         88          
==========================================
  Hits            501        501          
  Misses           34         34          
  Partials         17         17

Powered by Codecov. Last update 5d438e9...6fc5e3e

danielballan commented 8 years ago

This looks like a good fix to the sample data, but can you help me understand how the current code leads to an empty string?

licode commented 8 years ago

This is a bit confusing. I actually want to add data with str type. It looks like in old suitcase we can only save numerical data. That's why we need to do this change to test str type.

licode commented 8 years ago

We don't need to worry about data with empty str.