TST: Test that exceptions are included in mds object API.

NSLS-II / metadatastore

DEPRECATED: Incorporated into https://github.com/NSLS-II/databroker

Other

2 stars 11 forks source link

TST: Test that exceptions are included in mds object API. #250

Closed danielballan closed 7 years ago

danielballan commented 7 years ago

The main point of making this a formal unit test is ensuring that other MDS implementations don't forget to expose the exceptions as attributes.

ghost commented 7 years ago

Not as obsessed about coverage as @tacaswell lol

codecov-io commented 7 years ago

Current coverage is 89.70% (diff: 100%)

Merging #250 into master will increase coverage by 0.63%

@@             master       #250   diff @@
==========================================
  Files             4          4          
  Lines           476        476          
  Methods           0          0          
  Messages          0          0          
  Branches         75         75          
==========================================
+ Hits            424        427     +3   
+ Misses           37         34     -3   
  Partials         15         15

Powered by Codecov. Last update 54c2c0d...6cdeb79

danielballan commented 7 years ago

Haha, no problem, @arkilic. I only added these because I realized I want them for portable-mds. This kind of coverage doesn't mean much for metadatastore itself.

ghost commented 7 years ago

I imported them in mdclient like a crazy person as well. mdclient has mds as a requirement just because of these exceptions.

danielballan commented 7 years ago

As soon as this is merged I will kick off a PR into portable-mds that depends on this being in MDS master.

ghost commented 7 years ago

I will do the same in mdclient

danielballan commented 7 years ago

Great.