search

NSLS-II / metadatastore

DEPRECATED: Incorporated into https://github.com/NSLS-II/databroker
Other
2 stars 11 forks source link

API: auth=False by default until it is configurable #253

Closed danielballan closed 7 years ago

danielballan commented 7 years ago

There is no way to configure auth is the connection.yml, which means all analysis envs are broken by the default auth=True. We had better roll that back to be conservative. In a separate PR we can make auth configurable via the config files, test that it doesn't break anything, and then change the default back to True.

danielballan commented 7 years ago

This isn't even enough. MDS still fails. Stand by for more fixes. Really wish more people came to actual beamlines to actually test things.

codecov-io commented 7 years ago

Current coverage is 90.33% (diff: 100%)

Merging #253 into master will not change coverage

@@             master       #253   diff @@
==========================================
  Files             4          4          
  Lines           476        476          
  Methods           0          0          
  Messages          0          0          
  Branches         75         75          
==========================================
  Hits            430        430          
  Misses           31         31          
  Partials         15         15

Powered by Codecov. Last update e07b4d6...079e09c

danielballan commented 7 years ago

Sorry, that was unnecessarily snarky. I'm frustrated by how many things are broken at deploy-time.

danielballan commented 7 years ago

Will add test without auth on Travis to ensure we don't trip on this next time.